Template talk:WPBannerMeta

Archives
1, 2, 3, 4, 5, 6, 7, 8, 9, 10 11
Threads older than 28 days may be archived by lowercase sigmabot III.

Formatting error?

I recently updated the code for {{WikiProject Korea}} and inadvertently placed it in Category:WikiProject banners with formatting errors under code "N". This was caused by the removal of the TF_n_NAME parameters from {{WPBannerMeta/hooks/taskforces}} which I did because the documentation suggests that they are optional and redundant when TF_n_TEXT is also used. Restoring these parameters has fixed the problem but this looks like a false postive to me. PC78 (talk) 13:28, 1 September 2019 (UTC)

@PC78: You shouldn't need to use |TF_n_TEXT= if you are using |TF_n_NAME= and |TF_n_LINK= - when |TF_n_TEXT= is present, it completely overrides |TF_n_LINK=; and largely overrides |TF_n_NAME=, but there are certain parts of the code that rely on |TF_n_NAME= being set even when |TF_n_TEXT= is used. IIRC, using |TF_n_TEXT= is an old method that is retained for legacy reasons; if a template already uses |TF_n_NAME= and |TF_n_LINK=, don't switch it over. --Redrose64 🌹 (talk) 22:14, 1 September 2019 (UTC)

Hmm, the banner was already using |TF_n_TEXT= but removing it might simplify the code somewhat; on the other hand, the ability to define custom text seems useful and is not documented as a legacy feature. The banner appeared to be working fine without those parameters but I might just leave it now it's "fixed". PC78 (talk) 22:26, 1 September 2019 (UTC)

@PC78: Haven't looked in detail yet, but I think the TF NAME parameter is used for the default text when the banners are nested. — Martin (MSGJ · talk) 06:21, 18 September 2019 (UTC)

No, you're thinking of the {{WPBannerMeta/hooks/tfnested}} hook. I ended up making the change anyway, because the meagre benefits of maintaining custom text were outweighed by the simplification of the banner code. PC78 (talk) 10:47, 18 September 2019 (UTC)

You're right, but now I remember why the NAME parameter is mandatory - it is used by PageAssessments — Martin (MSGJ · talk) 10:53, 18 September 2019 (UTC)

The collapsed banner displays |TF_n_NESTED= whether tf hooks are used or not. --Redrose64 🌹 (talk) 14:41, 18 September 2019 (UTC)

Auto assess icon

Could someone please change the following in {{WPBannerMeta/core}}:

|{{WPBannerMeta/note
 |IMAGE=Robot icôn.svg
 |SIZE=30px

to:

|{{WPBannerMeta/note
 |IMAGE=Robot icôn.svg
 |SIZE={{{NOTE_SIZE|}}}

I don't see any reason why the auto assess icon should be handled differently to any other note icon, especially when the rest default to a diferent size. PC78 (talk) 01:00, 18 September 2019 (UTC)

Yes, that makes sense to me too — Martin (MSGJ · talk) 06:23, 18 September 2019 (UTC)

@PC78: please update in sandbox and validate testcases. If there is a missing test case for this condition, please make one and validate. — xaosflux ^Talk 13:49, 18 September 2019 (UTC)

@MSGJ: A little help? :) I've made changes to {{WPBannerMeta/core/sandbox}} and {{WPBannerMeta/sandbox}} and switched {{WikiProject Biography/sandbox}} over to the sandboxed meta... What am I missing? PC78 (talk) 15:37, 18 September 2019 (UTC)

If you tell us where your testcases are, we can look at what is happening. --Redrose64 🌹 (talk) 18:08, 18 September 2019 (UTC)

Ah... looks like it is working with the testcase at User talk:PC78/test banner; what's throwing me is why the change isn't visible at Template:WikiProject Biography/sandbox. PC78 (talk) 18:12, 18 September 2019 (UTC)

Testcases shouldn't be in a sandbox or in user space, they should be in Template: space - but for templates that are only used in a talk space, such as a WikiProject banner, they need to be in Template talk: space. Also, shey should be in a subpage whose name ends /testcases.

If your primary change is going to be made to Template:WikiProject Biography, the testcases should be at Template talk:WikiProject Biography/testcases; and if your primary change is going to be made to Template:WPBannerMeta or Template:WPBannerMeta/core, the testcases should be at Template talk:WPBannerMeta/testcases. More at WP:TESTCASES. --Redrose64 🌹 (talk) 18:57, 18 September 2019 (UTC)

None of that should make the slightest bit of difference... however, see test banner at {{WPBannerMeta/testcases}} and transclusion of test banner at Template talk:WPBannerMeta/testcases. Perhaps I'm being obtuse, but I don't see any other way of testing the code. PC78 (talk) 20:01, 18 September 2019 (UTC)

Tests at Template:WikiProject Biography/testcases check out fine — Martin (MSGJ · talk) 20:25, 18 September 2019 (UTC)

@MSGJ: Why does one from the sandbox have the auto row in a collapsed "More information:" section, whilst the live one has it exposed? Aside from that, does the robot head need to be that big? I thought we usually set the heights of note icons to be consistent. --Redrose64 🌹 (talk) 21:19, 18 September 2019 (UTC)

Cheers Martin, I'd just got there on my own but I see you beat me to it – that's what I get for trying to rush things at work when I should have done it properly at home! @Redrose64: That's exactly what this change will fix, the auto symbol will be handled like all other note icons. As for being collapsed, that depends entirely on the number of notes in the banner and the |COLLAPSED= setting. PC78 (talk) 22:36, 18 September 2019 (UTC)

The testcase at Template:WikiProject Biography/testcases#Auto assess uses exactly the same parameters for live and sandbox, therefore it should have exactly the same number of notes, therefore either both should collapse, or neither should. --Redrose64 🌹 (talk) 22:48, 18 September 2019 (UTC)

The sandboxed version of {{WikiProject Biography}} is not the same as the live version. PC78 (talk) 22:50, 18 September 2019 (UTC)

Yes! We Have No Bananas – Hopefully this constitutes a sufficient test? @Xaosflux: Can you please make this change to {{WPBannerMeta/core}}, assuming there are no further concerns? PC78 (talk) 00:37, 19 September 2019 (UTC)

@Xaosflux: (or someone else) I think we're good to implement this change now. PC78 (talk) 20:18, 23 September 2019 (UTC)

Haven't had time to review this yet - of course anyone else may. I will get to it eventually (always working the PERT queues). — xaosflux ^Talk 00:33, 24 September 2019 (UTC)

 Done @PC78: this has been done. Anyone should revert without consulting with me if this causes an immediate problem. — xaosflux ^Talk 13:01, 24 September 2019 (UTC)

How about adding FP as a class option?

Since it's getting widely used on file pages now, it might be useful to handle Featured pictures gracefully.... Thoughts? Adam Cuerden ^(talk)_{Has about 6.9% of all FPs} 21:39, 18 September 2019 (UTC)

We've got FM already, for Category:FM-Class articles: it can be used by setting |fm=yes inside {{class mask}}. This of course requires either |QUALITY_SCALE=inline or |QUALITY_SCALE=subpage in the {{WPBannerMeta}}. --Redrose64 🌹 (talk) 22:01, 18 September 2019 (UTC)

I think there's a case for renaming it FP-Class since it's used exclusively for Featured Pictures. Maybe that's a discussion for WP:VP though? PC78 (talk) 22:41, 18 September 2019 (UTC)

I would suggest leaving it at FM class just in case Wikipedia:Featured sounds ever gets restarted — Martin (MSGJ · talk) 11:21, 30 September 2019 (UTC)

What does ¬ do?

What does the ¬ character do in this template? Why is it important to use

{{{category|¬}}}

and not

{{{category|}}}

? I am asking because I was having trouble with Category:NA-Class Animals in media articles ( 0 ) depopulating after adding a class subpage to {{WikiProject Animals in media}}. I noticed that the ¬s were missing, added them, and the category emptied. --Nessie (talk) 19:11, 1 October 2019 (UTC)

It helps the template to spot the difference between |category= being present but blank, and being completely absent. --Redrose64 🌹 (talk) 20:13, 1 October 2019 (UTC)

It basically tells that whatever has ¬ in it isn't desired. So

{{{category|¬}}}

means 'don't categorize'. Headbomb {t · c · p · b} 20:14, 1 October 2019 (UTC)